[pgScript patch] Output + bug fix

From: Mickael Deloison <mdeloison(at)gmail(dot)com>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: [pgScript patch] Output + bug fix
Date: 2009-03-06 19:31:25
Message-ID: 1f8f052b0903061131i37b42b25w502346c5864e6396@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi pgAdmin hackers,

Here is a patch for pgAdmin. I have finally completed the patch for
the pgScript outputs and am sorry for the delay.
This patch also corrects a bug in pgsPrintStmt.cpp because of a thread
double lock in case of exception.
I have other updates to send but I would like this one to be committed first.

I have noticed while making this patch that the
pgQueryThread::GetMessagesAndClear() method does not return anything
when my query returns a warning. It did before.
The line 185 is:
conn->SetLastResultError(NULL);
Before, it was:
appendMessage(conn->GetLastError() + wxT("\n"));
When I put this line back to what it was, I do not have the problem
anymore. Is this a problem or is there another way to get the last
warning message?

Best regards,
Mickael

Attachment Content-Type Size
pgscript.patch.tar.gz application/x-gzip 1.6 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2009-03-06 20:21:48 Re: [pgScript patch] Output + bug fix
Previous Message Dave Page 2009-03-06 16:45:22 pgAdmin - notice of intent to change licence