Re: gcc -Wclobbered in PostgresMain

From: Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: gcc -Wclobbered in PostgresMain
Date: 2023-07-10 09:39:52
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello, Tom,

On 08.07.2023 18:11, Tom Lane wrote:
> What we ought to be doing is resetting these two flags
> after the disable_all_timeouts call.

Oops, I missed that.

> Having done that, it wouldn't really be necessary to mark these
> as volatile. I kept that marking anyway for consistency with
> send_ready_for_query, but perhaps we shouldn't?

I don't know. Maybe marking them volatile is more future proof. Not sure.

>> I also moved firstchar's declaration inside the loop where it's used, to
>> make it clear that this variable needn't be volatile and is not
>> preserved after longjmp().
> Good idea, but then why not the same for input_message? It's fully
> reinitialized each time through the loop, too.

Yeah, that's better.

> In short, something like the attached, except I'm not totally sold
> on changing the volatility of the timeout flags.

Looks good to me.

Thank you.

Sergey Shinderuk

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-07-10 09:54:04 Re: [Patch] Use *other* indexes on the subscriber when REPLICA IDENTITY is FULL
Previous Message Daniel Gustafsson 2023-07-10 09:37:47 Re: Some revises in adding sorting path