Re: ICU for global collation

On 13.09.22 07:34, Marina Polyakova wrote:
> I agree with you that it is more comfortable and more similar to what
> has already been done in initdb. IMO it would be easier to do it like this:
>
> diff --git a/src/bin/scripts/createdb.c b/src/bin/scripts/createdb.c
> index
> e523e58b2189275dc603a06324a2f28b0f49d8b7..a1482df3d981a680dd3322052e7c03ddacc8dc26 100644
> --- a/src/bin/scripts/createdb.c
> +++ b/src/bin/scripts/createdb.c
> @@ -161,12 +161,10 @@ main(int argc, char *argv[])
>
>      if (locale)
>      {
> -        if (lc_ctype)
> -            pg_fatal("only one of --locale and --lc-ctype can be
> specified");
> -        if (lc_collate)
> -            pg_fatal("only one of --locale and --lc-collate can be
> specified");
> -        lc_ctype = locale;
> -        lc_collate = locale;
> +        if (!lc_ctype)
> +            lc_ctype = locale;
> +        if (!lc_collate)
> +            lc_collate = locale;
>      }
>
>      if (encoding)

done that way

> Should we change the behaviour of createdb and CREATE DATABASE in
> previous major versions?..

I don't see a need for that.

>> BTW it's somewhat crummy that it uses a string comparison, so if you
>> write "UTF8" without a dash, it says this; it took me a few minutes to
>> see the difference...
>>
>> postgres=# create database a LC_COLLATE "en_US.UTF8" LC_CTYPE
>> "en_US.UTF8" LOCALE "en_US.UTF8";
>> ERROR:  new collation (en_US.UTF8) is incompatible with the collation
>> of the template database (en_US.UTF-8)
>
> Perhaps we could check the locale itself with the function
> normalize_libc_locale_name (collationcmds.c). But ISTM that the current
> check is a safety net in case the function pg_get_encoding_from_locale
> (chklocale.c) returns -1 or PG_SQL_ASCII...

This is not new behavior in PG15, is it?