| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: log_heap_visible(): remove unused parameter and update comment |
| Date: | 2022-10-04 08:18:43 |
| Message-ID: | 1f72c735-c897-0ad6-b149-aaf5d1c4fcf0@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04.10.22 09:19, Bharath Rupireddy wrote:
> We have the pg_attribute_unused() macro already. I'm not sure if
> adding -Wunused-parameter for compilation plus using
> pg_attribute_unused() for unused-yet-contextually-required variables
> is a great idea. But it has some merits as it avoids unused variables
> lying around in the code. However, we can even discuss this in a
> separate thread IMO to hear more from other hackers.
I tried this once. The patch I have from a few years ago is
420 files changed, 1482 insertions(+), 1482 deletions(-)
and it was a lot of work to maintain.
I can send it in if there is interest. But I'm not sure if it's worth it.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-10-04 08:24:19 | Re: interrupted tap tests leave postgres instances around |
| Previous Message | Peter Smith | 2022-10-04 08:16:36 | Re: Fix some newly modified tab-complete changes |