Re: Feature: temporary materialized views

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Mitar <mmitar(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Feature: temporary materialized views
Date: 2019-01-21 02:46:05
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 1/18/19 8:32 PM, Mitar wrote:
> On Fri, Jan 18, 2019 at 7:18 AM Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
>> These rules are usually pretty easy to add. Just take a look in
>> src/bin/psql/tab-complete.c to see how it is usually done.
> Thanks. I have added the auto-complete and attached a new patch.

Hm, I do not think we should complete UNLOGGED MATERIALIZED VIEW even
though it is valid syntax. If you try to create one you will just get an
error. I am leaning towards removing the existing completion for this,
because I do not see the point of completing to useless but technically
valid syntax.

This is the one I think we should probably remove:

else if (TailMatches("CREATE", "UNLOGGED"))

>> I might take a stab at refactoring this myself this weekend. Hopefully
>> it is not too involved.
> That would be great! I can afterwards update the patch accordingly.

I have submitted a first shot at this. Let's see what others think of my


In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tsunakawa, Takayuki 2019-01-21 02:57:34 RE: Thread-unsafe coding in ecpg
Previous Message Chapman Flack 2019-01-21 02:41:44 Re: PostgreSQL vs SQL/XML Standards