Re: fairywren is generating bogus BASE_BACKUP commands

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: fairywren is generating bogus BASE_BACKUP commands
Date: 2022-01-23 22:38:26
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 1/23/22 16:31, Andres Freund wrote:
>> The most common issues we get are around this issue of virtualized paths
>> in the TAP tests. If people followed the rule I suggested upthread, 99%
>> of those problems would go away. I realize it's annoying - I've been
>> caught by it myself on more than one occasion. Maybe there's a way to
>> avoid it, but if there is I'm unaware of it. But I don't think it's in
>> any way a good reason to drop msys support.
> Needing to sprinkle perl2host and MSYS2_ARG_CONV_EXCL over a good number of
> tests, getting weird errors when failing, etc IMO isn't a scalable approach,
> for a platform that most of use never use.
> Can't we solve this in a generic way? E.g. by insisting that the test run with
> a native perl and normalizing the few virtual paths we get invoked with
> centrally? Making the msys initial setup a bit more cumbersome would IMO be
> an OK price to pay for making it maintainable / predictable from other
> platforms, as long as we have some decent docs and decent error messages.

Nice idea. I have a suspicion that it's going to be harder than you
think, but I'll be very happy to be proved wrong.



Andrew Dunstan

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-01-23 22:59:32 Re: Replace uses of deprecated Python module distutils.sysconfig
Previous Message Andres Freund 2022-01-23 22:26:53 Re: XLogReadRecord() error in XlogReadTwoPhaseData()