From: | Denis Laxalde <denis(dot)laxalde(at)dalibo(dot)com> |
---|---|
To: | Anton Kirilov <antonvkirilov(at)gmail(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Add PQsendSyncMessage() to libpq |
Date: | 2023-04-27 11:06:27 |
Message-ID: | 1eb1a3f4-a820-9848-f73b-4456608c9166@dalibo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello,
Anton Kirilov a écrit :
> On 25/04/2023 15:23, Denis Laxalde wrote:
>> This sounds like a useful addition to me. I've played a bit with it in
>> Psycopg and it works fine.
>
> Thank you very much for reviewing my patch! I have attached a new
> version of it that addresses your comments and that has been rebased on
> top of the current tip of the master branch (by fixing a merge
> conflict), i.e. commit 7b7fa85130330128b404eddebd4f33c6739454b0.
>
> For the sake of others who might read this e-mail thread, I would like
> to mention that my patch is complete (including documentation and tests,
> but modulo review comments, of course), and that it passes the tests, i.e.:
>
> make check
> make -C src/test/modules/libpq_pipeline check
Thank you; this V2 looks good to me.
Marking as ready for committer.
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Verite | 2023-04-27 11:44:55 | Re: Add standard collation UNICODE |
Previous Message | Drouvot, Bertrand | 2023-04-27 10:54:30 | Re: Add two missing tests in 035_standby_logical_decoding.pl |