Re: doc: mentioned CREATE+ATTACH PARTITION as an alternative to CREATE TABLE..PARTITION OF

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, David Rowley <drowley(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: doc: mentioned CREATE+ATTACH PARTITION as an alternative to CREATE TABLE..PARTITION OF
Date: 2022-07-18 14:39:09
Message-ID: 1e91af94-2bea-5b35-49f3-ea14859c2a0d@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2022-07-18 Mo 10:33, Justin Pryzby wrote:
> It's easy to use CREATE TABLE..LIKE + ALTER..ATTACH PARTITION to avoid
> acquiring a strong lock when creating a new partition.
> But it's also easy to forget.
>
> commit 76c0d1198cf2908423b321cd3340d296cb668c8e
> Author: Justin Pryzby <pryzbyj(at)telsasoft(dot)com>
> Date: Mon Jul 18 09:24:55 2022 -0500
>
> doc: mention CREATE+ATTACH PARTITION as an alternative to CREATE TABLE..PARTITION OF
>
> See also: 898e5e3290a72d288923260143930fb32036c00c
> Should backpatch to v12
>
> diff --git a/doc/src/sgml/ref/create_table.sgml b/doc/src/sgml/ref/create_table.sgml
> index 6bbf15ed1a4..db7d8710bae 100644
> --- a/doc/src/sgml/ref/create_table.sgml
> +++ b/doc/src/sgml/ref/create_table.sgml
> @@ -619,6 +619,16 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
> with <literal>DROP TABLE</literal> requires taking an <literal>ACCESS
> EXCLUSIVE</literal> lock on the parent table.
> </para>
> +
> + <para>
> + Note that creating a partition acquires an <literal>ACCESS
> + EXCLUSIVE</literal> lock on the parent table.
> + It may be preferable to first CREATE a separate table and then ATTACH it,
> + which does not require as strong of a lock.
> + See <link linkend="sql-altertable-attach-partition">ATTACH PARTITION</link>
> + and <xref linkend="ddl-partitioning"/> for more information.
> + </para>
> +
> </listitem>
> </varlistentry>
>

Style nitpick.

I would prefer "does not require as strong a lock."

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-07-18 15:44:41 Re: [RFC] building postgres with meson - v10
Previous Message Justin Pryzby 2022-07-18 14:33:04 doc: mentioned CREATE+ATTACH PARTITION as an alternative to CREATE TABLE..PARTITION OF