| From: | Ian Barwick <barwick(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, olly(at)lfix(dot)co(dot)uk, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: 8.0b4: COMMIT outside of a transaction echoes ROLLBACK |
| Date: | 2004-10-31 08:20:33 |
| Message-ID: | 1d581afe0410310120430636a7@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, 30 Oct 2004 16:45:22 -0400, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> > On Wed, Oct 27, 2004 at 09:29:21PM -0400, Tom Lane wrote:
> >> Wouldn't it be better to just stay in TBLOCK_STARTED state, as if the
> >> COMMIT were just some random utility command?
>
> > It's the same thing, because CommitTransactionCommand acts identically
> > either way. I changed it anyway because it seems simpler.
>
> Patch applied.
Many thanks for this. I appreciate it's a fairly trivial issue, but
seeing the word "ROLLBACK" when a commit, or at least a non-operation
were expected, can do nasty things to one's blood pressure.
Ian Barwick
barwick(at)gmail(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuo Ishii | 2004-10-31 08:32:19 | Re: Charset/collate support and function parameters |
| Previous Message | Stefan Kaltenbrunner | 2004-10-31 07:54:17 | -HEAD regression failure on OpenBSD 3.6-current/x86 |