| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, noriyoshi(dot)shinoda(at)hpe(dot)com |
| Cc: | petr(dot)jelinek(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org, craig(at)2ndquadrant(dot)com |
| Subject: | Re: Logical Replication and Character encoding |
| Date: | 2017-03-03 19:37:55 |
| Message-ID: | 1d21f14f-f79e-2f3a-4953-7f6022996b33@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2/27/17 00:23, Kyotaro HORIGUCHI wrote:
> Yeah, the patch sends converted string with the length of the
> orignal length. Usually encoding conversion changes the length of
> a string. I doubt that the reverse case was working correctly.
I think we shouldn't send the length value at all. This might have been
a leftover from an earlier version of the patch.
See attached patch that removes the length value.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Logical-replication-protocol-fix.patch | text/x-patch | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-03-03 19:47:20 | Re: Restricting maximum keep segments by repslots |
| Previous Message | Peter Geoghegan | 2017-03-03 19:37:11 | Re: GUC for cleanup indexes threshold. |