Re: Broken SSL tests in master

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Broken SSL tests in master
Date: 2016-11-24 23:15:34
Message-ID: 1d0b9899-ff05-5bf0-53c8-4a1aa914d590@proxel.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/24/2016 10:38 PM, Andreas Karlsson wrote:
> To me it feels like the proper fix would be to make PQHost() return the
> value of the host parameter rather than the hostaddr (maybe add a new
> field in the pg_conn_host struct). But would be a behaviour change which
> might break someones application. Thoughts?

I have attached a proof of concept patch for this. Remaining work is
investigating all the callers of PQhost() and see if any of them are
negatively affected by this patch and cleaning up the code some.

Andreas

Attachment Content-Type Size
pgconn-hostaddr-fix-poc.patch text/x-patch 3.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2016-11-24 23:20:44 Re: UNDO and in-place update
Previous Message Robert Haas 2016-11-24 23:13:22 Re: Functions Immutable but not parallel safe?