| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
| Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Allow insert and update tuple routing and COPY for foreign table |
| Date: | 2019-04-26 04:20:31 |
| Message-ID: | 1cc7b8be-d201-8bad-5d98-350faccf095c@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Fujita-san,
On 2019/04/25 22:17, Etsuro Fujita wrote:
> (2019/04/24 22:04), Laurenz Albe wrote:
>> Before PostgreSQL v11, a foreign data wrapper could be certain that
>> BeginForeignModify is always called before ExecForeignInsert.
>> This is no longer true.
>
> OK, how about something like the attached? I reworded this a bit, though.
Thanks for the patch.
+ Note that this function is also called when inserting routed tuples into
+ a foreign-table partition or executing <command>COPY FROM</command> on
+ a foreign table, in which case it is called in a different way than it
+ is in the <command>INSERT</command> case.
Maybe minor, but should the last part of this sentence read as:
...in which case it is called in a different way than it is in the case
<command>INSERT</command> is operating directly on the foreign table.
?
Thanks,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2019-04-26 04:58:15 | Re: pgsql: Allow insert and update tuple routing and COPY for foreign table |
| Previous Message | Peter Geoghegan | 2019-04-25 19:50:55 | pgsql: Sanitize line pointers within contrib/amcheck. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2019-04-26 04:58:15 | Re: pgsql: Allow insert and update tuple routing and COPY for foreign table |
| Previous Message | Amit Langote | 2019-04-26 03:56:44 | findTargetlistEntrySQL92() and COLLATE clause |