Re: [PATCH] Add pretty-printed XML output option

From: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrey Borodin <amborodin86(at)gmail(dot)com>
Subject: Re: [PATCH] Add pretty-printed XML output option
Date: 2023-02-23 08:20:00
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 23.02.23 08:51, Peter Eisentraut wrote:
> In kwlist.h you have
> but you can actually make it BARE_LABEL, which is preferable.
> More importantly, you need to add the new keyword to the
> bare_label_keyword production in gram.y.  I thought we had some
> tooling in the build system to catch this kind of omission, but it's
> apparently not working right now.
Entry in kwlist.h changed to BARE_LABEL.
> Elsewhere, let's rename the xmlformat() C function to xmlserialize()
> (or maybe something like xmlserialize_indent()), so the association is
> clearer.
xmlserialize_indent sounds much better and makes the association indeed
clearer. Changed in v19.

v19 attached.

Thanks for the review!

Best, Jim

Attachment Content-Type Size
v19-0001-Add-pretty-printed-XML-output-option.patch text/x-patch 24.9 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-02-23 08:36:00 Re: pgindent vs. git whitespace check
Previous Message Peter Eisentraut 2023-02-23 07:51:47 Re: [PATCH] Add pretty-printed XML output option