| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Alvaro Herrera" <alvherre(at)alvh(dot)no-ip(dot)org>, "Rahila Syed" <rahilasyed90(at)gmail(dot)com> |
| Cc: | "Amit Kapila" <amit(dot)kapila16(at)gmail(dot)com>, "Tomas Vondra" <tomas(dot)vondra(at)enterprisedb(dot)com>, "Peter Smith" <smithpb2250(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Column Filtering in Logical Replication |
| Date: | 2021-09-07 22:39:30 |
| Message-ID: | 1c8ee74f-d393-42c7-b83d-dad991717a1a@www.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 6, 2021, at 2:51 PM, Alvaro Herrera wrote:
> I pushed the clerical part of this -- namely the addition of
> PublicationTable node and PublicationRelInfo struct. I attach the part
> of your v4 patch that I didn't include. It contains a couple of small
> corrections, but I didn't do anything invasive (such as pgindent)
> because that would perhaps cause you too much merge pain.
While updating the row filter patch [1] (because it also uses these
structures), I noticed that you use PublicationRelInfo as a type name instead
of PublicationRelationInfo. I choose the latter because there is already a data
structure named PublicationRelInfo (pg_dump.h). It is a client-side data
structure but I doesn't seem a good practice to duplicate data structure names
over the same code base.
[1] https://www.postgresql.org/message-id/0c2464d4-65f4-4d91-aeb2-c5584c1350f5%40www.fastmail.com
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-09-07 22:46:06 | Re: Allow escape in application_name (was: [postgres_fdw] add local pid to fallback_application_name) |
| Previous Message | Bossart, Nathan | 2021-09-07 22:36:18 | parallelizing the archiver |