Re: [Patch] Add missing libraries to Libs.private of libpq.pc

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Sandro Mani <manisandro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [Patch] Add missing libraries to Libs.private of libpq.pc
Date: 2020-09-04 20:07:00
Message-ID: 1c12e077-c7c3-7a84-4aba-b6c808d83fb8@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-07-10 21:47, Peter Eisentraut wrote:
> On 2020-04-08 11:38, Sandro Mani wrote:
>> The following patch, which we added to build mingw-postgresql on Fedora,
>> adds some missing libraries to Libs.private of libpq.pc, discovered when
>> attempting to statically link with libpq:
>>
>> -lz: is required by -lcrypto
>
> I think the correct fix for that would be to add libssl to libpq's
> Requires.private.

For that, I propose the attached patch.

>> -liconv: is required by -lintl (though possibly depends on whether
>> gettext was compiled with iconv support)

I think the solution here would be to have gettext provide a pkg-config
file.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Add-libpq-s-openssl-dependencies-to-pkg-config-file.patch text/plain 1.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2020-09-04 20:12:24 Re: BUG #16419: wrong parsing BC year in to_date() function
Previous Message Juan José Santamaría Flecha 2020-09-04 20:03:38 Re: A micro-optimisation for walkdir()