Re: xml_is_well_formed (was Re: buildfarm warnings)

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <rhaas(at)postgresql(dot)org>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>
Subject: Re: xml_is_well_formed (was Re: buildfarm warnings)
Date: 2022-02-13 23:34:00
Message-ID: 1c00965c-31bb-710b-1fd9-b582778492db@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2/13/22 13:59, Tom Lane wrote:
> So we're faced with a dilemma: we can't rename either instance without
> breaking something. The only way to get rid of the warnings seems to be
> to decide that the copy in xml2 has outlived its usefulness and remove
> it. I don't think that's a hard argument to make: that version has been
> obsolete since 9.1 (a0b7b717a), meaning that only pre-extensions versions
> of xml2 could need it. In fact, we pulled the trigger on it once before,
> in 2016 (20540710e), and then changed our minds not because anyone
> lobbied to put it back but just because we gave up on the PGDLLEXPORT
> rearrangement that prompted the change then.
>
> I think that getting rid of these build warnings is sufficient reason
> to drop this ancient compatibility function, and now propose that
> we do that.
>
>

+1

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-02-13 23:47:19 Re: bailing out in tap tests nearly always a bad idea
Previous Message Tom Lane 2022-02-13 23:32:59 Re: bailing out in tap tests nearly always a bad idea