|From:||Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>|
|To:||Robert Haas <robertmhaas(at)gmail(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>|
|Cc:||Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>|
|Subject:||Re: ATTACH/DETACH PARTITION CONCURRENTLY|
|Views:||Raw Message | Whole Thread | Download mbox|
On 2018/11/15 11:03, Amit Langote wrote:
> As Michael pointed out, the first cleanup patch needs to be rebased due to
> a recent commit . I did that to see if something we did in that commit
> made things worse for your patch, but seems fine. I had to go and change
> things outside RelationBuildPartitionDesc as I rebased, due to the
> aforementioned commit, but they're simple changes such as changing List *
> arguments of some newly added functions to PartitionBoundSpec **. Please
> find the rebased patches attached with this email.
>  https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=b52b7dc2
I noticed that the regression tests containing partitioned tables fail
randomly with the rebased patches I posted, whereas they didn't if I apply
them to HEAD without .
It seems to be due to the slightly confused memory context handling in
RelationBuildPartitionDesc after , which Alvaro had expressed some
doubts about yesterday.
I've fixed 0001 again to re-order the code so that allocations happen the
correct context and now tests pass with the rebased patches.
By the way, I noticed that the oids array added by Robert's original 0001
patch wasn't initialized to NULL, which could lead to calling pfree on a
garbage value of oids after the 2nd patch.
|Next Message||Noah Misch||2018-11-15 04:57:28||Re: [RFC] Removing "magic" oids|
|Previous Message||Tom Lane||2018-11-15 03:41:02||Re: lbound1 default in buildint2vector/buildoidvector|