Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone

From: "Euler Taveira" <euler(at)eulerto(dot)com>
To: "Renan Soares Lopes" <renans(dot)l(at)icloud(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone
Date: 2022-02-18 19:10:36
Message-ID: 1bcdc383-9856-4ddd-b975-d728a4f687c7@www.fastmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 18, 2022, at 2:47 PM, Renan Soares Lopes wrote:
> Hello,
>
> I added a patch to fix table_to_xmlschema, could you point me how to add a unit test to that?
You should edit src/test/regress/expected/xmlmap.out. In this case, you should
also modify src/test/regress/expected/xmlmap_1.out that the output from this
test when you build without libxml support. Run 'make check' to test your fix
after building with/without libxml support.

Regarding this fix, it looks good to me. FWIW, character class escape is
defined here [1].

[1] https://www.w3.org/TR/xmlschema11-2/#cces

--
Euler Taveira
EDB https://www.enterprisedb.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2022-02-18 19:19:49 Re: Time to drop plpython2?
Previous Message Robert Haas 2022-02-18 18:53:39 Re: adding 'zstd' as a compression algorithm