| From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | magnus(at)hagander(dot)net, Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgstat_send_connstats() introduces unnecessary timestamp and UDP overhead |
| Date: | 2021-09-06 07:37:55 |
| Message-ID: | 1bbf53a7fb6bab210a0f9185a208a0da6bc2a870.camel@cybertec.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2021-09-06 at 00:22 -0700, Andres Freund wrote:
> On 2021-09-06 09:12:58 +0200, Laurenz Albe wrote:
> > Reading your patch, I am still confused about the following:
> > There are potentially several calls to "pgstat_send_tabstat" in "pgstat_report_stat".
> > It seems to me that if it were called more than once, session statistics would
> > be reported and counted several times, which would be wrong.
>
> The accumulator variables are set to zero after being sent. So no data should
> be sent multiple times as far as I can tell.
Ah, I missed that. Then I see no problem with that approach.
Yours,
Laurenz Albe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiro Ikeda | 2021-09-06 07:48:35 | Re: Allow escape in application_name |
| Previous Message | REIX, Tony | 2021-09-06 07:31:45 | RE: AIX: Symbols are missing in libpq.a |