| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add pg_sequence system catalog |
| Date: | 2017-01-24 15:08:21 |
| Message-ID: | 1b722fdc-7f69-9033-2bed-34e318d61a74@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 1/19/17 11:03 AM, Stephen Frost wrote:
> I'd suggest using our usual approach in pg_dump, which is matching based
> on the OID, like so:
>
> WHERE c.oid = '%u'::oid
>
> The OID is in: tbinfo->dobj.catId.oid
>
> Also, you should move the selectSourceSchema() into the per-version
> branches and set it to 'pg_catalog' for PG10 and up, which would allow
> you to avoid having to qualify the table names, et al.
Does the attached patch look correct to you?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pg_dump-Fix-some-schema-issues-when-dumping-sequence.patch | text/x-patch | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-01-24 15:23:21 | Re: [COMMITTERS] pgsql: Add pg_sequence system catalog |
| Previous Message | Robert Haas | 2017-01-24 14:39:10 | pgsql: Fix incorrect comment: pgtime's tm_mon is 1-based, not 0-based. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-01-24 15:23:21 | Re: [COMMITTERS] pgsql: Add pg_sequence system catalog |
| Previous Message | Konstantin Knizhnik | 2017-01-24 15:08:05 | Active zombies at AIX |