| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |
| Date: | 2021-01-26 07:24:43 |
| Message-ID: | 1b4d7c4f-a9f9-08f0-295d-de6ec0d5def5@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/01/26 16:05, Tom Lane wrote:
> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>> Thanks for the review! I fixed them and pushed the patch!
>
> Buildfarm is very not happy ...
Yes.... I'm investigating that.
-- Return false as connections are still in use, warnings are issued.
SELECT postgres_fdw_disconnect_all();
-WARNING: cannot close dropped server connection because it is still in use
-WARNING: cannot close connection for server "loopback" because it is still in use
WARNING: cannot close connection for server "loopback2" because it is still in use
+WARNING: cannot close connection for server "loopback" because it is still in use
+WARNING: cannot close dropped server connection because it is still in use
The cause of the regression test failure is that the order of warning messages
is not stable. So I'm thinking to set client_min_messages to ERROR temporarily
when doing the above test.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-01-26 07:33:57 | Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit |
| Previous Message | Michael Paquier | 2021-01-26 07:22:56 | Re: Add SQL function for SHA1 |