| From: | Sergey <ls7777(at)yandex(dot)ru> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "orlovmg(at)gmail(dot)com" <orlovmg(at)gmail(dot)com>, "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: Patch for migration of the pg_commit_ts directory |
| Date: | 2026-07-27 10:41:00 |
| Message-ID: | 1b3c6a12-dc2b-4b10-b036-da3e9bb9cdf7@yandex.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I was writing emails in the browser. I am writing this letter and
sending it in the mail client. The letter format is plain text. I think
this should fix the problem.
You do not need to check for files in the pg_commit_ts directory in the
new cluster BEFORE the copy operation. These files are not needed. This
patch is designed to copy the pg_commit_ts directory from the old
cluster. If the user does not want to copy the pg_commit_ts directory,
it is enough not to specify the --pg-commit-ts option. This is the
default behavior. And for most, this is a suitable option.
27.07.2026 10:54, Hayato Kuroda (Fujitsu) пишет:
> Dear Sergey,
> (BTW, your mail looks broken on the web mail archive [1]. Please check settings)
>
>> Are you talking about checking for files in the pg_commit_ts directory of the old cluster?
>> The possibility of copying the catalog is checked here:
> No. IIUC, the code check whether the old node has a commit timestamps, and copies them
> if it has.
>
> My scenario was that if the NEW node has already had a commit timestamps. In this case,
> existing entries would be overwritten after the upgrade. Then my question was that whether
> we need to ensure there are no commit timestamp entries in the new cluster.
>
> [1]: https://www.postgresql.org/message-id/7105101784659908@mail.yandex.ru
>
> Best regards,
> Hayato Kuroda
> FUJITSU LIMITED
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tender Wang | 2026-07-27 10:41:19 | Re: Partition pruning can incorrectly exclude a RANGE default partition |
| Previous Message | Akshay Joshi | 2026-07-27 10:34:52 | Re: [PATCH] Add pg_get_table_ddl() to reconstruct CREATE TABLE statements |