| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Generate pg_stat_get_xact*() functions with Macros |
| Date: | 2023-01-06 08:44:25 |
| Message-ID: | 1b1222c8-ff02-7adc-4636-786e1dab6d3d@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 1/6/23 12:21 AM, Andres Freund wrote:
> Hi,
>
> On 2023-01-05 15:19:54 -0500, Corey Huinker wrote:
>> It does get me wondering, however, if we reordered the three typedefs to
>> group like-typed registers together, we could make them an array with the
>> names becoming defined constant index values (or keeping them via a union),
>> then the typedefs effectively become:
>
> I think that'd make it substantially enough harder to work with the
> datastructures that I don't want to go there.
>
Yeah, I think that's a good idea from a "coding style" point of view but harder to work with.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema | 2023-01-06 09:19:16 | Re: Sampling-based timing for EXPLAIN ANALYZE |
| Previous Message | Pavel Stehule | 2023-01-06 08:42:09 | Re: [RFC] Add jit deform_counter |