From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
Cc: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, jian he <jian(dot)universality(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: split func.sgml to separated individual sgml files |
Date: | 2025-10-02 19:57:56 |
Message-ID: | 1a609094-4baf-4980-be90-1b3232b35bb2@eisentraut.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 01.10.25 22:02, Andrew Dunstan wrote:
>
(Maybe these discussions could have been in a new thread and not hidden
under some unrelated thing.)
> OK, thanks, looks good. How do we go about doing what Tom wants (i.e.
> running the tests by default) under meson. I think in the Makefile we
> could just add it to the html target.
-html: html-stamp
+html: check html-stamp
This is not a good solution. This means the html target is never up to
date. Compare PostgreSQL 18:
$ make html
make: Nothing to be done for 'html'.
$ make -q html; echo $?
0
And master:
$ make html
perl ...
$ make -q html; echo $?
1
Also, consider the postgres-full.xml target:
# Run validation only once, common to all subsequent targets. While
# we're at it, also resolve all entities (that is, copy all included
# files into one big file). This helps tools that don't understand
# vpath builds (such as dbtoepub).
postgres-full.xml: postgres.sgml $(ALL_SGML)
$(XMLLINT) $(XMLINCLUDE) --output $@ --noent --valid $<
Note that this already does validation. The way this is structured now
is that it runs the validation once when you create postgres-full.xml,
which is than later input into the HTML generation, and then you run the
validation again, on the already-processed input files, which doesn't
make any sense.
I suspect what you're really after here is the functionality of the
check-tabs and check-nbsp targets. So the new Perl script really just
has to cover those two and doesn't have to bother with xmllint. And
then you just call that script as part of the postgres-full.xml target.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2025-10-02 20:16:02 | Re: split func.sgml to separated individual sgml files |
Previous Message | Masahiko Sawada | 2025-10-02 19:13:11 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |