| From: | "Euler Taveira" <euler(at)eulerto(dot)com> |
|---|---|
| To: | "Nathan Bossart" <nathandbossart(at)gmail(dot)com> |
| Cc: | "Jacob Champion" <jacob(dot)champion(at)enterprisedb(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, "Dave Cramer" <davecramer(at)gmail(dot)com>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: More protocol.h replacements this time into walsender.c |
| Date: | 2025-08-06 17:54:13 |
| Message-ID: | 1a1b279e-69d7-4609-924e-8d52f1201ef0@app.fastmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 6, 2025, at 12:26 AM, Nathan Bossart wrote:
> Okay, I think I've addressed all the latest feedback in v5.
>
LGTM.
I tried to apply your patch and it says
$ git am -3 v5-0001-Expand-usage-of-protocol-characters.patch
Applying: Expand usage of protocol characters.
Warning: commit message did not conform to UTF-8.
You may want to amend it after fixing the message, or set the config
variable i18n.commitEncoding to the encoding your project uses.
It seems your file is ISO-8859-1 but your commit message claims to be UTF-8.
--
Euler Taveira
EDB https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-08-06 18:01:29 | Re: More protocol.h replacements this time into walsender.c |
| Previous Message | Álvaro Herrera | 2025-08-06 17:39:36 | Re: Confine vacuum skip logic to lazy_scan_skip |