From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
---|---|
To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | katouknl(at)oss(dot)nttdata(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [PATCH] Add min() and max() aggregate functions for xid8 |
Date: | 2022-02-10 03:37:10 |
Message-ID: | 1a101cb1-7c9c-d018-4a85-694d708c244f@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2022/02/09 13:04, Kyotaro Horiguchi wrote:
> At Wed, 09 Feb 2022 12:04:51 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
>> At Wed, 9 Feb 2022 11:01:57 +0900, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote in
>>> Agreed. So barring any objection, I will commit that patch.
>>
>> Sorry for being late, but I don't like the function names.
>>
>> +xid8_larger(PG_FUNCTION_ARGS)
>> +xid8_smaller(PG_FUNCTION_ARGS)
>>
>> Aren't they named like xid8gt and xid8lt conventionally? At least the
>> name lacks a mention to equality.
>
> Ah, sorry. the function returns larger/smaller one from the
> parameters. Sorry for the noise.
Thanks for the review! I pushed the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
From | Date | Subject | |
---|---|---|---|
Next Message | houzj.fnst@fujitsu.com | 2022-02-10 03:59:16 | RE: row filtering for logical replication |
Previous Message | Julien Rouhaud | 2022-02-10 02:54:30 | Re: Database-level collation version tracking |