| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: logical decoding and replication of sequences, take 2 |
| Date: | 2023-07-14 14:31:49 |
| Message-ID: | 1a0460e5-7e42-d0ad-2a4d-4d0455e806fa@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7/14/23 16:02, Ashutosh Bapat wrote:
> ...
>>>>>
>>>>
>>>> Hmmmm, that might work. I feel a bit uneasy about having to keep all
>>>> relfilenodes, not just sequences ...
>>>
>>> From relfilenode it should be easy to get to rel and then see if it's
>>> a sequence. Only add relfilenodes for the sequence.
>>>
>>
>> Will try.
>>
>
> Actually, adding all relfilenodes to hash may not be that bad. There
> shouldn't be many of those. So the extra step to lookup reltype may
> not be necessary. What's your reason for uneasiness? But yeah, there's
> a way to avoid that as well.
>
> Should I wait for this before the second round of review?
>
I don't think you have to wait - just ignore the part that changes the
WAL record, which is a pretty tiny bit of the patch.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2023-07-14 14:42:43 | Re: PATCH: Using BRIN indexes for sorted output |
| Previous Message | Farias de Oliveira | 2023-07-14 14:30:38 | Re: In Postgres 16 BETA, should the ParseNamespaceItem have the same index as it's RangeTableEntry? |