Re: Reducing connection overhead in pg_upgrade compat check phase

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Reducing connection overhead in pg_upgrade compat check phase
Date: 2023-07-10 23:26:33
Message-ID: 1FE28680-333E-433C-9809-95662037B0AA@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 11 Jul 2023, at 01:09, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> On Mon, Jul 10, 2023 at 04:43:23PM +0200, Daniel Gustafsson wrote:

>>> +static int n_data_types_usage_checks = 7;
>>>
>>> Can we determine this programmatically so that folks don't need to remember
>>> to update it?
>>
>> Fair point, I've added a counter loop to the beginning of the check function to
>> calculate it.
>
> + /* Gather number of checks to perform */
> + while (tmp->status != NULL)
> + n_data_types_usage_checks++;
>
> I think we need to tmp++ somewhere here.

Yuk, yes, will fix when caffeinated. Thanks.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jacob Champion 2023-07-10 23:50:22 Re: [PoC] Federated Authn/z with OAUTHBEARER
Previous Message Peter Smith 2023-07-10 23:23:36 Re: doc: improve the restriction description of using indexes on REPLICA IDENTITY FULL table.