| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, "Bharath Rupireddy" <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: make MaxBackends available in _PG_init |
| Date: | 2022-01-10 19:01:32 |
| Message-ID: | 1E960D8B-24D7-43E0-9744-C5F8C52DDEB4@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 1/7/22, 12:27 PM, "Robert Haas" <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Jan 7, 2022 at 1:09 PM Bossart, Nathan <bossartn(at)amazon(dot)com> wrote:
>> While that approach would provide a way to safely retrieve the value,
>> I think it would do little to prevent the issue in practice. If the
>> size of the patch is a concern, we could also convert MaxBackends into
>> a macro for calling GetMaxBackends(). This could also be a nice way
>> to avoid breaking extensions that are using it correctly while
>> triggering ERRORs for extensions that are using it incorrectly. I've
>> attached a new version of the patch that does it this way.
>
> That's too magical for my taste.
Fair point. v4 [0] is the less magical version.
Nathan
[0] https://postgr.es/m/attachment/125445/v4-0001-Disallow-external-access-to-MaxBackends.patch
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-01-10 19:31:38 | Isn't wait_for_catchup slightly broken? |
| Previous Message | rajesh singarapu | 2022-01-10 18:56:03 | Postgres Replication from windows to linux |