Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: bt23nguyent <bt23nguyent(at)oss(dot)nttdata(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
Date: 2024-03-04 20:27:23
Message-ID: 1DFBEAE6-01A6-49E8-8360-BA9113E33092@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 4 Mar 2024, at 18:22, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Mon, Mar 04, 2024 at 03:21:59PM +0100, Daniel Gustafsson wrote:
>> Looking at this again I think this is about ready to go in. My only comment is
>> that doc/src/sgml/archive-modules.sgml probably should be updated to refer to
>> setting the errdetail, especially since we document the errormessage there.
>
> Thanks for reviewing. How does this look?

Looks good from a read-through, I like it. A few comments on the commit
message only:

actionable details about the source of the miconfiguration. This
s/miconfiguration/misconfiguration/

Reviewed-by: Daniel Gustafsson, ¡lvaro Herrera
Alvaro's name seems wrong.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2024-03-04 20:39:37 Re: Improving btree performance through specializing by key shape, take 2
Previous Message Tomas Vondra 2024-03-04 20:07:04 Re: Shared detoast Datum proposal