| From: | Asim Praveen <pasim(at)vmware(dot)com> |
|---|---|
| To: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, MBeena Emerson <mbeena(dot)emerson(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: recovering from "found xmin ... from before relfrozenxid ..." |
| Date: | 2020-08-13 07:06:14 |
| Message-ID: | 1D56CEFD-E195-4E6B-B870-3383E3E8C65E@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Ashutosh
I stumbled upon this thread today, went through your patch and it looks good. A minor suggestion in sanity_check_relation():
if (rel->rd_rel->relam != HEAP_TABLE_AM_OID)
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
errmsg("only heap AM is supported")));
Instead of checking the access method OID, it seems better to check the handler OID like so:
if (rel->rd_amhandler != HEAP_TABLE_AM_HANDLER_OID)
The reason is current version of sanity_check_relation() would emit error for the following case even when the table structure is actually heap.
create access method myam type table handler heap_tableam_handler;
create table mytable (…) using myam;
Asim
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2020-08-13 07:31:51 | Re: [PG13] Planning (time + buffers) data structure in explain plan (format text) |
| Previous Message | Thomas Munro | 2020-08-13 06:57:20 | Re: WIP: WAL prefetch (another approach) |