Re: Cold welcoming message when installing anything because of LLVM bitcode stuff

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org,Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cold welcoming message when installing anything because of LLVM bitcode stuff
Date: 2018-04-28 18:14:59
Message-ID: 1CB09A95-2F38-4E60-9160-3CB9EC1D3B4E@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On April 28, 2018 11:05:15 AM PDT, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> JIT is introducing the installation of LLVM bitcode modules, and any
>> installation done results in the following comment in output, which
>> repeats basically for all the extensions installed:
>> # Then install files
>> #
>> # The many INSTALL_DATA invocations aren't particularly fast, it'd be
>> # good if we could coalesce them, but I didn't find a good way.
>
>> Andres, could it be possible to move at least that block of comments
>in
>> a place where this is not user-visible?

Yes, that seems sensible. I don't think they hurt much given the existing verbosity, but they don't add anything.

> Close inspection of the
>"make install" output revealed a few other issues, which I hope
>I fixed rather than making things worse.

Broke the llvm enabled part of the bf. Will have a look once I'm home (1.5h), unless you get to it first.

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-04-28 18:32:06 Re: Cold welcoming message when installing anything because of LLVM bitcode stuff
Previous Message Tom Lane 2018-04-28 18:05:15 Re: Cold welcoming message when installing anything because of LLVM bitcode stuff