Enhance Makefiles to rebuild objects on map file changes

From: Chao Li <lic(at)highgo(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Enhance Makefiles to rebuild objects on map file changes
Date: 2025-08-06 04:41:46
Message-ID: 1CA8625F-AA41-4ED2-B60F-E28AC71F37DC@highgo.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Community,

While working on the upgrade from GB18030 to GB18030-2022, I updated two GB18030-related map files. However, rebuilding PostgreSQL did not recompile anything, which led me to discover that the Makefiles under src/backend/utils/mb/conversion_procs were missing dependency rules between NAME.o and the corresponding map files.

This patch adds the necessary dependencies to ensure that when a map file changes, the corresponding .o file is rebuilt accordingly.

I have done tests for every Makefile I changed in a way like:

# make a change to a map file
$ make
# a .o got rebuilt
$ make # make again without map file change
# nothing re-compiled

Chao Li (Evan)
--------------------
HighGo Infra. Software Inc.
https://www.highgo.com/

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2025-08-06 04:49:32 Re: Bug in pg_dump --filter? - Invalid object types can be misinterpreted as valid
Previous Message Sami Imseih 2025-08-06 04:24:04 Re: Improve LWLock tranche name visibility across backends