| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Minor pg_amcheck fixes spotted while reading code |
| Date: | 2021-08-23 07:37:40 |
| Message-ID: | 1B9997F7-BA1D-4B2E-A272-AEBDD457D08E@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 21 Aug 2021, at 02:43, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Aug 20, 2021 at 11:42:09AM -0700, Mark Dilger wrote:
>> These look correct.
>
> static void
> -help(const char *progname)
> +help(const char *program_name)
> These were discussed not long ago, and I recall that they were in the
> we-don't-care category. Note for example all the tools of
> src/scripts/ and pg_dump/.
Fair enough, I had missed that thread.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-08-23 08:13:01 | Re: Separate out FileSet from SharedFileSet (was Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o) |
| Previous Message | Masahiko Sawada | 2021-08-23 07:37:27 | Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o |