| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Improve OAuth discovery logging |
| Date: | 2026-03-16 08:30:05 |
| Message-ID: | 1B58D836-6B8F-4B9A-9B84-08965E5AA06B@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 16 Mar 2026, at 12:32, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> Thanks for the quick review!
>
>> pg_stat_database.sessions_fatal seems to be still incremented, but, probably,
>> we can live with it. But also we can fix it.
>
> We are still doing a fatal disconnect, so it seems appropriate to me?
Makes sense. We must see this activity somewhere. Even establishing connection is
a big deal, let alone TLS handshake.
>
>> Changes to send_message_to_server_log()
>> ...
>> FATAL_CLIENT_ONLY = 23 sits between FATAL (22) and PANIC (24).
>
> I handled these the same way as the existing WARNING_CLIENT_ONLY. We
> can change it, but then we probably should also update the warning
> case.
Ahh, OK.
>
>> Does this assignment have an effect?
>
> No, but that's also true for the other already existing assignment in
> this branch, I think these are mostly there for internal
> bookkeeping/consistency?
OK.
One more nit: errdetail("Empty request, discovery requested?").
Question marks are uncommon in errdetail and errmsg.
I have no more comments about the patch, feel free to flip it to RfC.
Best regards, Andrey Borodin.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2026-03-16 08:31:45 | Re: Odd code around ginScanToDelete |
| Previous Message | Fujii Masao | 2026-03-16 08:27:19 | Re: Add missing stats_reset column to pg_statio_all_sequences view |