Re: citext operator precedence fix

On Sep 22, 2011, at 11:07 AM, Alvaro Herrera wrote:

>> That is the test file. The main SQL file is citext--1.0.sql. You'll actually need to bump the version number to 1.1, rename that file to citext--1.1.sql, and also add them to a citext--1.0--1.1.sql. There probably also needs to be a citext--unpackaged--1.1.sql file.
>
> Hmm, if there's a citext--unpackaged--1.0.sql and also
> citext--1.0--1.1.sql, is it really necessary to have
> citext--unpackaged--1.1.sql? Shouldn't the upgrade facility be able to
> just run both scripts?

No, because if 1.1 was installed on 8.4, you'd need the commands to move all its functions into the extension, not re-create them.

However, since this ships with core, it's probably not necessary, because theoretically no one will use it in 8.4, so the functions will never be unpackaged.

Best,

David