Re: [PATCH] Improve geometric types

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Emre Hasegeli <emre(at)hasegeli(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Improve geometric types
Date: 2018-07-29 20:35:17
Message-ID: 19ea110a-1258-443e-e370-d8734eaa2e91@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 07/29/2018 05:11 PM, Tomas Vondra wrote:
>
>
> On 07/29/2018 04:31 PM, Jeff Janes wrote:
>>
>>
>> On Sat, Jul 28, 2018 at 9:54 PM, Tomas Vondra
>> <tomas(dot)vondra(at)2ndquadrant(dot)com <mailto:tomas(dot)vondra(at)2ndquadrant(dot)com>> wrote:
>>
>>
>>
>> I've committed the first two parts, after a review and testing.
>>
>>
>> I'm getting a compiler warning now:
>>
>> geo_ops.c: In function 'line_closept_point':
>> geo_ops.c:2528:7: warning: variable 'retval' set but not used
>> [-Wunused-but-set-variable]
>>   bool  retval;
>>  
>
> Yeah, the variable is apparently only used in an assert. Will fix.
>

This should fix it I guess, and it's how we deal with unused return
values elsewhere. I've considered using USE_ASSERT_CHECKING here, but it
seems rather ugly with that. I'll wait for Emre's opinion ...

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
geo-compiler-warning.patch text/x-patch 696 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-07-29 20:57:44 Re: [PATCH] Improve geometric types
Previous Message Peter Geoghegan 2018-07-29 19:45:06 Re: Tips on committing