From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling) |
Date: | 2017-01-19 18:06:20 |
Message-ID: | 19999.1484849180@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2017-01-18 16:56:46 -0500, Tom Lane wrote:
>> Andres Freund <andres(at)anarazel(dot)de> writes:
>> I have not actually looked at 0003 at all yet. So yeah, please post
>> for review after you're done rebasing.
> Here's a rebased and lightly massaged version.
I've read through this and made some minor improvements, mostly additional
comment cleanup. One thing I wanted to ask about:
@@ -4303,7 +4303,7 @@ inline_function(Oid funcid, Oid result_type, Oid result_collid,
/*
* Forget it if the function is not SQL-language or has other showstopper
- * properties. (The nargs check is just paranoia.)
+ * properties. (The nargs and retset checks are just paranoia.)
*/
if (funcform->prolang != SQLlanguageId ||
funcform->prosecdef ||
I thought this change was simply wrong, and removed it; AFAIK it's
perfectly possible to get here for set-returning functions, since
the planner does expression simplification long before it worries
about splitting out SRFs. Did you have a reason to think differently?
Other than that possible point, I think the attached is committable.
regards, tom lane
Attachment | Content-Type | Size |
---|---|---|
no-srfs-in-tlists-cleanup-2.patch.gz | application/x-gzip | 27.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2017-01-19 18:12:29 | Re: Logical Replication WIP - FailedAssertion, File: "array_typanalyze.c", Line: 340 |
Previous Message | Petr Jelinek | 2017-01-19 18:03:29 | Re: Logical replication existing data copy |