Re: [HACKERS] Source code format vote

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Source code format vote
Date: 1999-12-30 17:09:24
Message-ID: 199912301709.MAA13119@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Current votes are:
> > (8) 8-space tabs: Tom Lane, Peter E., Massimo, Jan, Hiroshi, Peter M.,
> > Michael, Tatsuo
> > (5) 4-space tabs: Bruce, Andreas, Vince, Vadim, D'Arcy
>
> > open bracket on if () line:
> > (7) yes: Massimo, Peter, Vince, Tom Lane, Peter M., Marc, Tatsuo
> > (6) no: Bruce, Vadim, D'Arcy, Jan, Hiroshi, Michael M.
>
> > Looks like radical change will come to our source code format for 7.0.
>
> It looks to me like there is consensus to change the tab spacing (which
> is NOT the same as the logical indent step, for those newcomers who
> don't seem to be aware of the difference).
>
> However, I don't see a consensus to change the bracket layout.
> 7-to-6 is not enough of a margin to justify a wholesale code change.
> Especially considering that my original vote was NO, which Bruce chose
> to interpret as YES ;-). Change it back to NO, and the vote is the
> other way.
>
> I think what we have is a consensus to change the physical tab spacing
> but leave the look of the code alone...

OK, change tab to 8 spaces, keep indent at 4 spaces, and keep open
bracked on a separate line. Got it.

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Lamar Owen 1999-12-30 21:08:04 RPMS on PostgreSQL.org updated.
Previous Message Bruce Momjian 1999-12-30 17:07:35 Re: AW: [HACKERS] correlated subquery