Re: [HACKERS] Tuple toaster (was: Re: LONG varsize - how to go on)

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Jan Wieck <wieck(at)debis(dot)com>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Tuple toaster (was: Re: LONG varsize - how to go on)
Date: 1999-12-21 02:12:27
Message-ID: 199912210213.VAA09459@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Bruce Momjian wrote:
>
> > I think Vadim had a single entry point that he could control in that
> > way. Not sure Jan has such an entry point. If the stuff goes all over
> > the place, #ifdef can be hard to read as you are coding.
>
> Sure, there will be some more entry points this time. But as
> far as I see up to now, not too many in the beginning. And
> for storing values, they're all located in heapam.c.

Good.

>
> Who uses an editor that cannot distinguish between tabstop
> and shiftwidth? And which editors are these - are they useful
> for programming at all?
>
> Anyway, I vote for 8-space tabs and 4-space indents too. My
> .exrc set's up 4-space tabs actually, and it's a real mess
> when editing non-PG sources.

OK, that tips the scales in favor of 8-char tabs. My micro-emacs can't
handle different indent and tab sizes, but that is an old non-X-based
editor. I then checked Crisp, my new X editor, and I can't see how to
that either.

However, I don't do that much coding, so if people want to go for 8-byte
tabs and 4-byte indent, we can do that.

Any objections on for that?

> You can do anything you want soon. I intend only to put the
> #ifdef'd out calls to the toaster into heapam.c, and create a
> new tuptoaster.c in the same location, again all code
> #ifdef'd out. From then on, I can work CVS based without any
> interference.

Let me know.

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1999-12-21 02:14:14 Re: [HACKERS] LONG vs. Toaster
Previous Message Bruce Momjian 1999-12-21 02:09:10 Re: [HACKERS] T-O-A-S-T meaning