Re: [HACKERS] Re: [PATCHES] COMMENT ON patch

From: Mike Mascari <mascarim(at)yahoo(dot)com>
To: Byron Nikolaidis <byron(dot)nikolaidis(at)home(dot)com>
Cc: peter_e(at)gmx(dot)net, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Re: [PATCHES] COMMENT ON patch
Date: 1999-10-25 05:18:15
Message-ID: 19991025051815.3737.rocketmail@web2104.mail.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

--- Byron Nikolaidis <byron(dot)nikolaidis(at)home(dot)com> wrote:
...
> > I still need to write the SGML and change pg_dump to
> > generate COMMENT ON statements, and also regression tests,
> > but the functionality should be complete. Just glancing
> > over the Win32 ODBC driver, it appears that SQLTables() and
> > SQLColumns() is not currently fetching the associated
> > description from pg_description for the REMARKS parameter
> > to the call. Perhaps this could be changed?
>
> It wouldn't be hard to add the pg_description to the remarks.
> Does this field exist for all previous postgres releases (specifically,
> 6.2,6.3, and 6.4) ??
>
> Byron
...

It appears, just from a spot check of the initial database structure
created from old RPMS on rpmfind.net that pg_description was added
after 6.2 whose "provides" looks like this (for 6.2.1):

...
/var/lib/postgresql/data/base/template1/pg_attrdefind
/var/lib/postgresql/data/base/template1/pg_attrelidind
/var/lib/postgresql/data/base/template1/pg_attribute
/var/lib/postgresql/data/base/template1/pg_class
/var/lib/postgresql/data/base/template1/pg_classnameind
/var/lib/postgresql/data/base/template1/pg_classoidind
/var/lib/postgresql/data/base/template1/pg_index
/var/lib/postgresql/data/base/template1/pg_inheritproc
/var/lib/postgresql/data/base/template1/pg_inherits
/var/lib/postgresql/data/base/template1/pg_internal.init
...

while for 6.3.1, the initial database structure looks like:

...
/var/lib/pgsql/base/template1/pg_class
/var/lib/pgsql/base/template1/pg_class_oid_index
/var/lib/pgsql/base/template1/pg_class_relname_index
/var/lib/pgsql/base/template1/pg_description
/var/lib/pgsql/base/template1/pg_description_objoid_index
/var/lib/pgsql/base/template1/pg_index
/var/lib/pgsql/base/template1/pg_inheritproc
...

And of course, it appears also in 6.4.x, so I assume that it was added
between the 6.2 and 6.3 releases. Is that going to be a problem?

Hope that helps,

Mike Mascari
(mascarim(at)yahoo(dot)com)

__________________________________________________
Do You Yahoo!?
Bid and sell for free at http://auctions.yahoo.com

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mike Mascari 1999-10-25 05:18:57 Re: [HACKERS] Re: [PATCHES] COMMENT ON patch
Previous Message Bruce Momjian 1999-10-25 03:47:53 Book on web site