Re: [HACKERS] PATCH for pgconnection.h

This is the second mention of 'namespace' I have seen. Can we allow
this by default?

Of course, I get:

pgconnection.h:26: warning: namespaces are mostly broken in this version of g++

but it still works. Comments?

> I am using the Sun Workshop C 5.0, noticed that I was getting the
> following errors:
> "pgconnection.h", line 65: Error: string is not defined.
> "pgconnection.cc", line 134: Error: string is not defined.
> "pgconnection.cc", line 139: Error: Cannot return char* from a function
> that should return int.
> 3 Error(s) detected.
>
> Futher looking noticed that the standard namespace was not being used
> for the "string" typedef, so the following patch fixed that for me.
> This is for the 6.5 tar release & the 6/24 CVS checkout.
>
> vlad: diff -w3c interfaces/libpq++/pgconnection.h.orig
> interfaces/libpq++/pgconnection.h
> *** interfaces/libpq++/pgconnection.h.orig Thu Jun 24 10:49:54 1999
>
> --- interfaces/libpq++/pgconnection.h Thu Jun 24 10:48:31 1999
> ***************
> *** 23,28 ****
> --- 23,34 ----
> #include <stdio.h>
> #include <string>
>
> + #ifdef __sun__
> + #ifndef __GNUC__
> + using namespace std;
> + #endif
> + #endif
> +
> extern "C" {
> #include "libpq-fe.h"
> }
>
>
> --
> Brian Millett
> Enterprise Consulting Group "Heaven can not exist,
> (314) 205-9030 If the family is not eternal"
> bpm(at)ec-group(dot)com F. Ballard Washburn
>
>
>
>
>

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026