Re: [HACKERS] I can't compile cvs snapshot ...

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] I can't compile cvs snapshot ...
Date: 1999-05-26 15:06:19
Message-ID: 199905261506.LAA25278@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> If pgindent mucks up standard C constructs then pgindent is broken.
>
> This is not open to debate --- if you are going to run our entire
> source base through pgindent just a few days before every release,
> then the tool has to be something we can have 100 percent, no-questions-
> asked confidence in. Telling people to obey weird little coding
> conventions is no answer. (If everyone reliably did that, we'd not
> need pgindent in the first place.)
>
> It appears that BSD indent doesn't have a problem with 0xnnnL, so
> teaching it about 0xnnnU can't be that hard if you have the source.
> (I don't...)

OK, here is the patch that is not in the tools/pgindent directory to
understand 0x7fU constants. I will put the U's back in the constants.

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Attachment Content-Type Size
unknown_filename text/plain 439 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 1999-05-26 15:06:30 Re: [HACKERS] Help: fmgr_info: function 0: cache lookup failed
Previous Message Tom Lane 1999-05-26 14:18:09 Re: [HACKERS] Memory leak in large objects (was Re: Postgreqsl Large Objects)