Re: [HACKERS] discussion on proposed int8_ops patch

Applied, though there was some wrapping of the e-mail I had to clean up.

Your hash code looks fine, so I enabled it by removing the ifdef's. You
could XOR the top int4 bytes with the bottom int4 bytes, but I doubt
there is a portable way to do that, so you are better off just leaving
it as is, where it looks at only the lower int32 bytes.

If you copied how the other entries pointed to other entries, your code
will be fine.

> Hello hackers...
>
> Enclosed below I have a patch to allow a btree index on the int8 type.
>
> I would like some feedback on what the hash function for the int8 hash function
> in the ./backend/access/hash/hashfunc.c should return.
>
> Also, could someone (maybe Tomas Lockhart?) look-over the patch and make sure
> the system table entries are correct? I've tried to research them as much as I
> could, but some of them are still not clear to me.
>

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026