From: | Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> |
---|---|
To: | hackers(at)postgresql(dot)org |
Subject: | inet data type regression test fails |
Date: | 1999-02-22 02:54:39 |
Message-ID: | 199902220254.LAA04354@srapc451.sra.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi all,
The inet regression test has been failed on my LinuxPPC. While
investigating the reason, I found a code that doesn't work on
LinuxPPC. From network_broadcast() in utils/adt/network.c:
int addr = htonl(ntohl(ip_v4addr(ip)) | (0xffffffff >> ip_bits(ip)));
Here ip_bits() returns from (unsigned char)0 to 32. My question is:
what is the correct result of (0xffffffff >> ip_bits())?
1. 0x0
2. 0xffffffff (actually does nothing)
LinuxPPC is 1. FreeBSD and Solaris are 2. network_broadcast() seems to
expect 2. My guess is shifting over 32bit against a 32bit integer is
not permitted and the result is platform depedent. If this would true,
it could be said that network_broadcast() has a portabilty
problem. Comments?
---
Tatsuo Ishii
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas G. Lockhart | 1999-02-22 02:58:46 | Re: [COMMITTERS] 'pgsql/src/test/regress/expected rules.out' |
Previous Message | D'Arcy J.M. Cain | 1999-02-21 22:28:14 | Re: [HACKERS] Update contributors page |