Re: [HACKERS] Syntax errors in current tree

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: darcy(at)druid(dot)net (D'ArcyJ(dot)M(dot)Cain)
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Syntax errors in current tree
Date: 1999-01-18 06:48:07
Message-ID: 199901180648.BAA26158@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> really hesitate to make this criticism given all the work people are
> doing on the system and all the great features and fixes that are
> being added but could we please make it a hard and fast rule that
> nothing gets added into the tree until the person adding it has at
> least compiled the source, if not a full regression test. I have
> finally jumped in and tried to add full primary key support but I
> keep stumbling over simple syntax errors in files I am not working
> on but that keep me from fully testing my own changes. Here's what
> I get compiling gram.y[c].

Fixed. I assume people test the patches before submission, so I don't
usually compile after each one. I did add some code in gram.y, and that
was what caused the problem.

Sorry. Blech (Sound of me falling on my sword. :-))

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vadim Mikheev 1999-01-18 07:13:30 Re: [HACKERS] I need a PostgreSQL vacation
Previous Message Bruce Momjian 1999-01-18 06:20:44 Re: [HACKERS] Syntax errors in current tree