Re: [PATCHES] TCL/TK configuration fixes for PostgreSQL 6.4

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: Bill(dot)Allie(at)mug(dot)org
Cc: hackers(at)postgreSQL(dot)org, patches(at)postgreSQL(dot)org
Subject: Re: [PATCHES] TCL/TK configuration fixes for PostgreSQL 6.4
Date: 1998-10-18 04:18:58
Message-ID: 199810180418.AAA20758@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Applied.

> The TCL/TK configuration cleanup patches I submitted have the following
> problem:
>
> 'tclsh' still had to be found even if --with-libs (or --with-libraries) was
> specified to configure.
>
> --with-libs is really an overloaded option. It really should only be used
> to specify additions directories to search in order to file needed
> libraries. It was also being used to locate the *Config.sh files.
>
> This patch addresses these problems by:
>
> 1. Creating a new option (--with-tclconfig) which is used to specify the
> location of the *Config.sh files. If the tkConfig.sh is located in a
> different location than the tclConfig.sh, you can give both locations
> seperated by a space. For example:
>
> --with-tclconfig="/opt/lib/tcl8.0 /opt/lib/tk8.0"
>
> 2. Changing the search logic so that if '--with-tclconfg' is specified, then
> the tcl shell program is not used to obtain a list of directories to search
> for the *Config.sh files. It is assumed that the directories given with
> the --with-tclconfig option will contain the *Config.sh files.
>
> 3. Adding 'tcl' as a name of the tcl shell program to be searched for if
> 'tclsh' was not found in the PATH. This seems to be another common name
> for the tcl shell program.
>
> This patch also moves the clean-up of the generated Makefile.tcldefs and
> Makefile.tkdefs in bin/pgtclsh from GNUmakefile.in to the Makefile in
> bin/pgtclsh (where, IMHO, they belong).
Content-Description: uw7-1.patch

[Attachment, skipping...]

> ____ | Billy G. Allie | Domain....: Bill(dot)Allie(at)mug(dot)org
> | /| | 7436 Hartwell | Compuserve: 76337,2061
> |-/-|----- | Dearborn, MI 48126| MSN.......: B_G_Allie(at)email(dot)msn(dot)com
> |/ |LLIE | (313) 582-1540 |

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1998-10-18 04:42:32 Re: [HACKERS] SELECT ... LIMIT (trial implementation)
Previous Message Bruce Momjian 1998-10-18 04:11:11 Re: [PATCHES] TCL/TK configuration fixes for PostgreSQL 6.4