Re: [HACKERS] version functions (was NT port of PGSQL - success)

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: jwieck(at)debis(dot)com
Cc: jhickey(at)impact1(dot)hpcc(dot)nectec(dot)or(dot)th, pgsql-hackers(at)hub(dot)org
Subject: Re: [HACKERS] version functions (was NT port of PGSQL - success)
Date: 1998-10-09 16:39:17
Message-ID: 199810091639.MAA12025@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> No, it is still correct. The version function is there and it
> returns the compiled in string from version.h.
>
> But take a look at version.c please. I think it should use
> memcpy() or strncpy() instead of strcpy(). As it is now it
> writes the null byte after the palloc'ed area.

Yes, thanks. Fixed using StrNCpy().

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1998-10-09 16:43:59 Re: [PATCHES] PL patches (one more)
Previous Message Tom Lane 1998-10-09 15:01:29 Re: [HACKERS] Open 6.4 items