Re: [HACKERS] list macro names

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: dg(at)informix(dot)com (David Gould)
Cc: hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] list macro names
Date: 1998-08-29 04:25:31
Message-ID: 199808290425.AAA29575@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> >
> > I will, of course, be running pgindent on the source just before beta.
> >
> > I would also like to change a few of list macro names that I can never
> > remember, and I am sure others have the same problem.
> >
> > ---------------------------------------------------------------------------
> >
> > lappend is good
> >
> > lcons should be ladd (adds to the front of the list, while lappend adds to end
> But 'cons' is the absolute standard lisp nomemclature for this. And all these
> operations are part of the lispish heritage of postgres.
>
> > nconc should be lconcat, because it concats two lists
> >
> > lconsi becomes ladd_int
>
> And this adds an integer arithemetically or listwise? Not less confusing, just
> a different confusion.
>
> > lappendi becomes lappend_int
> >
> > nreverse becomes lreverse
> >
> > set_difference becomes set_difference_int
>
> Why is this more clear?
>
> What is next, Hungarian notation?
>
> > What do people think?
>
> I think we should not rework code that everyone is getting used to unless
> there is some functional reason.
>
> -dg
>
> David Gould dg(at)informix(dot)com 510.628.3783 or 510.305.9468
> Informix Software (No, really) 300 Lakeside Drive Oakland, CA 94612
> - If simplicity worked, the world would be overrun with insects. -
>

OK, I seem to the only one who wants the change. They stay as is.

--
Bruce Momjian | 830 Blythe Avenue
maillist(at)candle(dot)pha(dot)pa(dot)us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1998-08-29 04:37:24 IP data type
Previous Message Bruce Momjian 1998-08-29 04:24:10 Re: PostgreSQL under BSD/OS