Re: new MB patch and pg_type oid problem

> >>Multi-byte pg_class_mb.h and others had duplicate copies of the file in
> >>them. I am committing a fix now.
> >
> >Thanks.
> >
> >>As far as I am concerned, if you want to just add the endcoding field to
> >>various tables, go ahead. It is easier than maintaining two copies of
> >>the files, and should make your job easier.
> >
> >Thanks again! If there's no objection, I will go ahead.
>
> Included patches are mainly for this purpose.
>
> o note that now pg_database has a new attribuite "encoding" even if
> MULTIBYTE is not enabled. So be sure to run initdb.
>
> o these patches are made against the latest source tree (after Bruce's
> massive patch, I think) BTW, I noticed that after running regression,
> the oid field of pg_type seems disappeared.
>
> regression=> select oid from pg_type;
> ERROR: attribute 'oid' not found

I just tried:

select oid from pg_type;

and it worked.

>
> this happens after the constraints test. This occures with/without my
> patches. strange...

What contraints test?

>
> o pg_database_mb.h, pg_class_mb.h, pg_attribute_mb.h are no longer
> used, and shoud be removed.
>
> o GetDatabaseInfo() in utils/misc/database.c removed (actually in
> #ifdef 0). seems nobody uses.

--
Bruce Momjian | 830 Blythe Avenue
maillist(at)candle(dot)pha(dot)pa(dot)us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)